Dmitry Antipov <dmantipov@xxxxxxxxx> writes: > On 9/21/23 02:15, Brian Norris wrote: > >> Have you tested this patch? You've certainly caught a logic bug, but >> that doesn't mean the seemingly obvious solution actually works. > > Unfortunately by eyes only :-(. IIUC there should be a weird hardware > stall to trigger an execution of the branch in subject, so I'm not sure > how to actually test it even if I would have an access to the hardware. I don't know about Brian but for me testing for regressions is the most important part. If the patch is only compile tested it could break the whole driver without anyone noticing. And then it's in a release and too late. That's why I have been asking you to add "Compile tested only" to the commit log so that it's obvious to everyone that your patches have received zero testing but you don't seem to care. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches