Wu Yunchuan <yunchuan@xxxxxxxxxxxx> wrote: > No need cast (void*) to (struct hal_rx_ppdu_end_user_stats *), > (struct ath12k_rx_desc_info *) or (struct hal_tx_msdu_ext_desc *). > Change the prototype to remove the local variable. > > Signed-off-by: Wu Yunchuan <yunchuan@xxxxxxxxxxxx> > Suggested-by: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx> > Signed-off-by: Kalle Valo <quic_kvalo@xxxxxxxxxxx> This added new warnings: drivers/net/wireless/ath/ath12k/dp_mon.c:25: line length of 92 exceeds 90 columns drivers/net/wireless/ath/ath12k/dp_mon.c:26: line length of 95 exceeds 90 columns I fixed them in the pending branch by renaming ppdu_end_user to stats and moving rx_user_status to it's own line: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=5c0910fdf1d800f1aeb8ab3e860e61bebec0091b No need to resend because of this. -- https://patchwork.kernel.org/project/linux-wireless/patch/20230919045142.524226-1-yunchuan@xxxxxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
