On Fri, Sep 01, 2023 at 01:16:00PM +0200, 'Toke Høiland-Jørgensen' via HUST OS Kernel Contribution wrote: > > Before sending this patch, I searched in the code, there are many call > > sites of ath_chanctx_event with argument vif as NULL. > > > > Functions calling this function: ath_chanctx_event > > > > File Function Line > > 0 beacon.c ath9k_beacon_tasklet 459 ath_chanctx_event(sc, vif, > > ATH_CHANCTX_EVENT_BEACON_PREPARE); > > But only this one has ATH_CHANCTX_EVENT_BEACON_PREPARE as an argument, > which is required to hit the code path you are changing. > Btw, if you have the cross function database enabled then Smatch will parse this code correctly. No false positive. regards, dan carpenter