Search Linux Wireless

Re: [PATCH] mac80211: don't assume driver has been attached on registration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 14, 2008 at 2:44 PM, Luis R. Rodriguez
<lrodriguez@xxxxxxxxxxx> wrote:
> mac80211's ieee80211_register_hw() is often called within the
> probe path so it cannot assume the device's driver structure
> has been attached yet so to create a workqueue instead of
> using driver->name use the wiphy's phy%d name. The name doesn't
> really matter anyway.
>
> This should fix sporadic oopses found when we race to beat the
> driver pointer setting. Not even sure how this was working properly.
>
> http://www.kerneloops.org/search.php?search=ieee80211_register_hw
>
> Signed-off-by: Luis R. Rodriguez <lrodriguez@xxxxxxxxxxx>
> Acked-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>

This is not necessary actually, it took a while to wrap my head around
the possible chicken and the egg problem (thanks to Bob for beating my
head to it) but at least I verified this is not an issue at least on
>= 2.6.25 as the device's driver *is* assigned prior to probe. This
patch however should make reading this a bit easier and the since the
naming doesn't matter maybe its best to apply it to make things
simpler. Up to you.

  Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux