On 2023/9/1 17:19, Johannes Berg wrote:
Hi,
Do you mean it shouldn't be allowed to set mcast rate when dev
is stopped,
Probably?
as in the following code?
--- a/net/wireless/rdev-ops.h
+++ b/net/wireless/rdev-ops.h
@@ -1229,7 +1229,7 @@ rdev_set_mcast_rate(struct
cfg80211_registered_device *rdev,
int ret = -ENOTSUPP;
trace_rdev_set_mcast_rate(&rdev->wiphy, dev, mcast_rate);
- if (rdev->ops->set_mcast_rate)
+ if (rdev->ops->set_mcast_rate && netif_running(dev))
ret = rdev->ops->set_mcast_rate(&rdev->wiphy, dev,
Certainly not. Please don't do random patches without looking at the
subsystem as a whole. If you don't want to take the time to understand
how things work in wireless, then better don't send patches at all.
johannes
Hi johannes:
It's a little difficult for me to solve this warning. This
warning has been going on for more than one year. Could you help solve
it? Thank you.
links:
https://groups.google.com/g/syzkaller-bugs/c/FofxpVlkONg/m/v296EFNnAAAJ
Zhengchao Shao
