Search Linux Wireless

Re: [PATCH net,v2] wifi: mac80211: fix WARNING in ieee80211_link_info_change_notify()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,


> 	Do you mean it shouldn't be allowed to set mcast rate when dev
> is stopped,
> 

Probably?

>  as in the following code?
> 
> --- a/net/wireless/rdev-ops.h
> +++ b/net/wireless/rdev-ops.h
> @@ -1229,7 +1229,7 @@ rdev_set_mcast_rate(struct 
> cfg80211_registered_device *rdev,
>          int ret = -ENOTSUPP;
> 
>          trace_rdev_set_mcast_rate(&rdev->wiphy, dev, mcast_rate);
> -       if (rdev->ops->set_mcast_rate)
> +       if (rdev->ops->set_mcast_rate && netif_running(dev))
>                  ret = rdev->ops->set_mcast_rate(&rdev->wiphy, dev, 
> 

Certainly not. Please don't do random patches without looking at the
subsystem as a whole. If you don't want to take the time to understand
how things work in wireless, then better don't send patches at all.

johannes




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux