On Sat, Nov 15, 2008 at 11:15:47AM +0300, Andrey Borzenkov wrote: > - we should not be doing it in ->open. It is technically legal to set > wireless parameters before "icfonfig up" and we lose all of them. I will > try next week with similar patch in orinoco_stop(). That seems wrong... > - I am still not even sure we should do it at all. What is sematic of > ifconfig up/down w.r.t. wireless parameters? I.e. is "ifconfig down" > expected to clean all device state and start from scratch? No. Unfortunately, it is mostly a matter of opinion as to what wireless extensions expects. FWIW, some drivers (particularly mac80211-based ones) require the device to be 'down' in order to change the mode (i.e. "managed", "ad-hoc", etc). Further, some drivers (particularly mac80211-based ones) use the setting of the SSID as a trigger for an association. So for example, bringing-up a mac80211-based device needs to look something like this: ifconfig wlan0 down iwconfig wlan0 mode Managed ifconfig wlan0 up iwconfig wlan0 essid SSID Beyond that, taking the device down would probably cause a loss of association. So later marking it up would be insufficient without also (re-)setting the SSID. But, e.g. channel settings should remain in effect. Hopefully I haven't confused the issue -- I'll stop now. :-) John -- John W. Linville Linux should be at the core linville@xxxxxxxxxxxxx of your literate lifestyle. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
