Hello David, On Mon, Aug 28, 2023 at 09:30:08AM +0000, David Lin wrote: > > On Tue, Aug 15, 2023 at 07:09:25AM +0000, David Lin wrote: > > > 1. For station mode first. > > > 2. This feature is a must for WPA3. > > > 3. Firmware key api version 2 is needed for this feature. > > > 4. The code is only enabled and tested with IW416. > > > 5. This feature is disabled for other chips. > > > > > > Signed-off-by: David Lin <yu-hao.lin@xxxxxxx> > > > > I think you are missing a few of the comments you received so far. > > > > - verify the recipient list, the list here was likely generated with an > > old kernel tree using an outdated MAINTAINERS file > > I followed your suggestion and issued the command on latest wireless test repository. Weird, you should have Brian Norris as recipient. > > - you need to provide a changelog in your patch, otherwise is not > > possible for other to review > > Yes, one the cover page. Whoops. I missed this since I am not cc: on this series and just found it by chance. I would have just expected to have the changelog together with the patch and not on the cover, given that it's a single patch. Sorry for the misunderstanding, I would appreciate if you could keep me in CC from now on, thanks. Francesco
