Hello David, thanks for your patch. On Tue, Aug 15, 2023 at 07:09:25AM +0000, David Lin wrote: > 1. For station mode first. > 2. This feature is a must for WPA3. > 3. Firmware key api version 2 is needed for this feature. > 4. The code is only enabled and tested with IW416. > 5. This feature is disabled for other chips. > > Signed-off-by: David Lin <yu-hao.lin@xxxxxxx> I think you are missing a few of the comments you received so far. - verify the recipient list, the list here was likely generated with an old kernel tree using an outdated MAINTAINERS file - you need to provide a changelog in your patch, otherwise is not possible for other to review - some concern were raised on the fact that this is tested only with IW416, we should have some confidence this is not creating regressions. Francesco
