Sorry, I completely dropped the ball on this. On Fri, 2023-03-31 at 10:55 -0700, Aloka Dixit wrote: > > How is ieee80211_set_bitrate_mask() related, it's in mac80211? > > > > Oh you mean it doesn't need to be changed to support EHT? Looks like to > > me that it would have to be changed, and even HE today only works in > > non-mac80211 drivers that implement it correctly? > > > > But again set_bitrate_mask() isn't even related to beacon rate? > > > > > > Regarding beacon rate, it looks like mac80211 _only_ accepts legacy > > rates, and then also _only_ in start_ap(), so I'm not sure how the whole > > thing even works ...?? > > > > I agree with all of your points and as said above, I mainly tested by > checking the final mask generated in nl80211.c. > > Do you remember a similar discussion when HE code was added (I wasn't > the submitter). May be that will have some pointers regarding how it was > tested. > > Do you think we can continue with this EHT support for non-mac80211 > drivers similar to HE for now? > Or should we just skip this patch? I don't know? I guess you need it somehow? Can we fix mac80211? Or maybe just make it clear that it won't work there? To be honest, it's not really in my head anymore now, unfortunately. What exactly do you need? Maybe we can work back from that. johannes
