On 3/30/2023 3:44 AM, Johannes Berg wrote:
On Tue, 2023-03-28 at 17:09 -0700, Aloka Dixit wrote:
+ switch (wdev->iftype) {
+ case NL80211_IFTYPE_AP:
+ width = wdev->u.ap.preset_chandef.width;
This seems a bit awkward and annoying, it means that we have to keep
using the API that sets the preset_chandef first, and it also means it
won't work for multi-link.
Okay, I can do it the same with it is done in he_get_txmcsmap():
chandef = wdev_chandef(wdev, link_id);
Couldn't you link it with the config in start_ap/join_mesh? And per-link
config in set_tx_bitrate_mask()?
Please correct me if I'm wrong but ieee80211_set_bitrate_mask() need not
be changed for setting the beacon rate in non-MLO case, right?
Because it does not have anything related to he_mcs currently too.
Also not sure about this at all in parse_tid_conf()?
Can you please explain this point.
I didn't find existing HWSIM support for this feature so I mainly tested
manually - setting the beacon rate in hostapd and checking that the mask
generated in nl80211.c is valid.
Thanks.
