Wen Gong <quic_wgong@xxxxxxxxxxx> wrote: > Currently, the encoding rule for field mlo_capable in struct > qmi_wlanfw_host_cap_req_msg_v01 defined in array > qmi_wlanfw_host_cap_req_msg_v01_ei uses type QMI_OPT_FLAG. > > Unfortunately, all ath12k firmware actually expects this field to be of > type NON QMI_OPT_FLAG such as QMI_UNSIGNED_1_BYTE/QMI_UNSIGNED_8_BYTE... > And as a result, firmware is unable to correctly decode the mlo_capable > field. > > Change the ath12k definition as QMI_UNSIGNED_1_BYTE to match the firmware > definition so that firmware can correctly parse the mlo_capable info from > message QMI_WLANFW_HOST_CAP_REQ_V01 at wlan load time. > > This is just an accidental typo and that both WCN7850 and QCN9274 firmwares > use QMI_UNSIGNED_1_BYTE. > > Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0-03427-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.15378.4 > > Signed-off-by: Wen Gong <quic_wgong@xxxxxxxxxxx> > Signed-off-by: Kalle Valo <quic_kvalo@xxxxxxxxxxx> Patch applied to ath-next branch of ath.git, thanks. 15c8441dc1ed wifi: ath12k: correct the data_type from QMI_OPT_FLAG to QMI_UNSIGNED_1_BYTE for mlo_capable -- https://patchwork.kernel.org/project/linux-wireless/patch/20230726093857.3610-1-quic_wgong@xxxxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
