On 7/25/23 18:08, Kalle Valo wrote:
There was no response from Dmitry but I suspect this was not tested on a real device. Submitting patches like this without any real testing is a bad idea as the risk of regressions is high. Please _always_ test patches on a real device. Only exception are trivial patches which can be easily reviewed.
Note there was a 2nd version of this, see https://patchwork.kernel.org/project/linux-wireless/patch/20230717084400.57882-1-dmantipov@xxxxxxxxx. I'm not insisting on accepting this patch as is, but hope that developers at Microchip should be capable to consider it for their next major driver update. Dmitry