<Ajay.Kathat@xxxxxxxxxxxxx> writes: > Hi Dmitry, > > On 7/13/23 01:26, Dmitry Antipov wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you >> know the content is safe >> >> Drop unused second argument of TX callback functions and use >> 'struct txq_entry_t *' as the only argument, thus removing >> 'struct wilc_p2p_mgmt_data', 'struct tx_complete_mon_data' >> and 'struct tx_complete_data' (actually intended just to >> pass callbacks parameters) as well. This also shrinks >> 'struct txq_entry_t' by 'priv' field and eliminates a few >> 'kmalloc()/kfree()' calls (at the cost of having dummy >> stack-allocated 'struct txq_entry_t' instances). > > I'm just curious to know if you have tested this patch with the real > hardware. There was no response from Dmitry but I suspect this was not tested on a real device. Submitting patches like this without any real testing is a bad idea as the risk of regressions is high. Please _always_ test patches on a real device. Only exception are trivial patches which can be easily reviewed. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
