Brian Norris <briannorris@xxxxxxxxxxxx> writes: > On Thu, Jul 20, 2023 at 09:55:38AM +0300, Kalle Valo wrote: >> We have four maintainers for mwifiex and total silence: >> >> MARVELL MWIFIEX WIRELESS DRIVER >> M: Amitkumar Karwar <amitkarwar@xxxxxxxxx> >> M: Ganapathi Bhat <ganapathi017@xxxxxxxxx> >> M: Sharvari Harisangam <sharvari.harisangam@xxxxxxx> >> M: Xinming Hu <huxinming820@xxxxxxxxx> >> L: linux-wireless@xxxxxxxxxxxxxxx >> S: Maintained >> F: drivers/net/wireless/marvell/mwifiex/ >> >> I'm very close of marking this driver as orphan unless anyone steps up. >> This is not how to maintain a driver. > > I'd be fully on board with removing these maintainers, as I don't recall > hearing from any of them in years. (In fact, some of these addresses > don't have a single mail logged on lore.kernel.org/all/...) I just > didn't want to be the one to say it. > > On the other hand, I regularly look at pretty much anything for mwifiex, > as long as the submitter is in relatively good faith. So I wouldn't mind > being a Reviewer (or Maintainer? what's the difference, when Kalle > does the committing anyway?). Heh, that's a good question. I don't know what was the original intent for a reviewer role but in my view ideally a driver should 1-2 maintainers, no more, and if there are more people involved they should be reviewers. And maintainers should use Acked-by, Reviewers should use Reviewed-by. And if I see an Acked-by from a maintainer I usually don't review the patch so closely and just take it directly (of there are exceptions, as always). In this case I would prefer you being the maintainer, even if you wouldn't have much time for mwifiex. But I don't know how others see it. Jakub has been writing documentation about maintainership which is also a good read: https://lore.kernel.org/all/20230719183225.1827100-1-kuba@xxxxxxxxxx/ > And that might qualify as "Odd Fixes", as > I don't plan on doing much more than keeping the lights on. > > I'll submit the MAINTAINERS patch if you'd like. Sounds very good to me, thank you! Please submit the patch if you can. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
