On Sat, 2023-07-15 at 17:00 -0700, Ben Greear wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> On 7/15/23 4:54 AM, Lorenzo Bianconi wrote:
> >> On 5/12/23 15:29, Lorenzo Bianconi wrote:
> >>> mib_stats structure is shared by mostly all chipsets. Move it to
> shared
> >>> code.
> >>
> >> In case this thing hasn't been pushed upstream yet, then a
> suggestion:
> >>
> >> Create a struct mt76_mib_stats_common class that has the common
> counters,
> >> and then per-driver can have that struct as first member of its
> mib stats.
> >>
> >> I have added a lot of per-driver stats that never made it upstream
> >> and are not fully shared across different drivers.
> >
> > I would say mt76_mib_stats is quite a general name. I think we can
> do somothing
> > like (if it is really necessary):
> >
> > struct mt7915_mib_stats {
> > struct mt76_mib_stats mt76;
> > ...
> > };
>
> Maybe:
>
> struct mt7915_mib_stats {
> struct mt76_mib_stats common;
> ...
> };
>
> I also noticed that Ryder added a few of my patches that extended the
> stats, so I think there are probably a lot of stats in that struct
> that are not set on the 7921 driver and probably older drivers too.
>
> To me, unset stats are confusing, so I'd prefer to put stats that are
> mostly
> common in a common struct, and have per-driver stats just found in
> the driver
> itself.
>
Myabe you can add a patch for per-driver stuff. I just extended the
stat for mt7915 and lore also sent this patch for common struct, but
ended up merging together.
Ryder
