> On 5/12/23 15:29, Lorenzo Bianconi wrote:
> > mib_stats structure is shared by mostly all chipsets. Move it to shared
> > code.
>
> In case this thing hasn't been pushed upstream yet, then a suggestion:
>
> Create a struct mt76_mib_stats_common class that has the common counters,
> and then per-driver can have that struct as first member of its mib stats.
>
> I have added a lot of per-driver stats that never made it upstream
> and are not fully shared across different drivers.
I would say mt76_mib_stats is quite a general name. I think we can do somothing
like (if it is really necessary):
struct mt7915_mib_stats {
struct mt76_mib_stats mt76;
...
};
Regards,
Lorenzo
>
> Thanks,
> Ben
>
> >
> > Signed-off-by: Lorenzo Bianconi <lorenzo@xxxxxxxxxx>
> > ---
> > drivers/net/wireless/mediatek/mt76/mt76.h | 63 +++++++++++++++++++
> > .../wireless/mediatek/mt76/mt7915/debugfs.c | 4 +-
> > .../net/wireless/mediatek/mt76/mt7915/mac.c | 2 +-
> > .../net/wireless/mediatek/mt76/mt7915/main.c | 4 +-
> > .../wireless/mediatek/mt76/mt7915/mt7915.h | 63 +------------------
> > 5 files changed, 69 insertions(+), 67 deletions(-)
> >
> > diff --git a/drivers/net/wireless/mediatek/mt76/mt76.h b/drivers/net/wireless/mediatek/mt76/mt76.h
> > index 75b5c2c56a92..45bf1022a051 100644
> > --- a/drivers/net/wireless/mediatek/mt76/mt76.h
> > +++ b/drivers/net/wireless/mediatek/mt76/mt76.h
> > @@ -857,6 +857,69 @@ struct mt76_dev {
> > };
> > };
> > +/* per-phy stats. */
> > +struct mt76_mib_stats {
> > + u32 ack_fail_cnt;
>
> --
> Ben Greear <greearb@xxxxxxxxxxxxxxx>
> Candela Technologies Inc http://www.candelatech.com
>
>
Attachment:
signature.asc
Description: PGP signature
