Search Linux Wireless

Re: [PATCH v2] wifi: rtw89: debug: fix error code in rtw89_debug_priv_btc_manual_set

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



在 2023年7月15日星期六 CST 下午5:22:08,Markus Elfring 写道:
> > If there is a failure during kstrtobool_from_user()
> > rtw89_debug_priv_btc_manual_set should return negative error code
> > instead of returning the count driectly.
> > 
> > Fix this bug by returning the correct error code.
> 
> How do you think about to use an other wording approach
> (like the following) for an improved change description?
> 
> 
>   Return an error code instead of a count after a failed call
>   of the function “kstrtobool_from_user”.
>   Omit the label “out” with this source code correction.
> 
> 
> Regards,
> Markus
Thanks for your kindness reply and advice and I will change my description
in the next version.

Regards,
Shurong







[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux