On Thu, 2023-06-22 at 19:43 +0200, Johannes Berg wrote:
> On Thu, 2023-06-22 at 17:47 +0300, Dan Carpenter wrote:
> >
> > 4922 if (control & IEEE80211_MLE_STA_CONTROL_COMPLETE_PROFILE &&
> > ^^
> > Should this be ||?
> >
> > 4923 control & IEEE80211_MLE_STA_CONTROL_NSTR_BITMAP_SIZE) {
> > 4924 if (control & IEEE80211_MLE_STA_CONTROL_NSTR_BITMAP_SIZE)
> >
> > This is always true because it's checked on the previous line.
> >
>
> Oops. There are actually two places doing this, I think I copy/pasted
> it.
>
> But the second part of the if statement should simply be removed.
Actually that's wrong, it should check the present bit :) Anyway, fixed,
thanks.
johannes
