On Thu, 2023-06-22 at 17:47 +0300, Dan Carpenter wrote:
>
> 4922 if (control & IEEE80211_MLE_STA_CONTROL_COMPLETE_PROFILE &&
> ^^
> Should this be ||?
>
> 4923 control & IEEE80211_MLE_STA_CONTROL_NSTR_BITMAP_SIZE) {
> 4924 if (control & IEEE80211_MLE_STA_CONTROL_NSTR_BITMAP_SIZE)
>
> This is always true because it's checked on the previous line.
>
Oops. There are actually two places doing this, I think I copy/pasted
it.
But the second part of the if statement should simply be removed. The
COMPLETE_PROFILE bit indicates whether or not the NSTR bitmap is
present, and the NSTR_BITMAP_SIZE bit indicates how it's encoded (8 or
16 bits).
Thanks!
johannes
