On Tue, 2008-11-11 at 10:02 +0530, Vivek Natarajan wrote: > 1) I see from your patch that power save is enabled whenever there > is no Tx for the specified 'timeout' period. Should we also take into > account the type of power connection( i.e battery or direct ac supply) > before enabling PS? That's userspace policy, we only provide the mechanism to set the required state. > 2) Do you intend to leave the NULL frame formation, waking up the chip > for TIM and modifying sleep/awake time according to DTIM to > the driver since I did not see this in your TODO list?( I understand from > the iwlwifi code that it just sends a request to the firmware for sending > NULL frame and the firmware takes care of the rest. But it may not be > so in the case of other vendor drivers.) Can you elaborate on this? I don't think we're concerned with that in dynPS. > 3) Is the PS-POLL concept(or M frames in N milliseconds concept of Johannes) > dropped after the DNS response timings related discussion that you had > since it might save some more power in low-traffic conditions? It might save more power, but it seems that the compromise is too strongly in favour of power for the dynPS mode, so you can just do static PS all the time instead. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
