On Sun, Nov 9, 2008 at 9:13 PM, Kalle Valo <kalle.valo@xxxxxxxxx> wrote:
>
> Here's my first version of dynamic powersave patches. I have tested them
> only with stlc45xx on Nokia N810. Unfortunately stlc45xx's psm command is
> buggy and I haven't been able to run any longer tests, yet. Next week I will
> also test with iwl3945.
>
> These are RFC patches, not to be applied.
>
> TODO:
> o Johannes' subif_start_xmit suggestion
> o test with intel hardware (only in-tree driver using IEEE80211_CONF_PS)
> o disable power save when software scanning
> o association check to the work structs?
> o cancel_work_sync()
>
Hello Kalle,
I have a few questions on the PS implementation. Here they are,
1) I see from your patch that power save is enabled whenever there
is no Tx for the specified 'timeout' period. Should we also take into
account the type of power connection( i.e battery or direct ac supply)
before enabling PS?
2) Do you intend to leave the NULL frame formation, waking up the chip
for TIM and modifying sleep/awake time according to DTIM to
the driver since I did not see this in your TODO list?( I understand from
the iwlwifi code that it just sends a request to the firmware for sending
NULL frame and the firmware takes care of the rest. But it may not be
so in the case of other vendor drivers.)
3) Is the PS-POLL concept(or M frames in N milliseconds concept of Johannes)
dropped after the DNS response timings related discussion that you had
since it might save some more power in low-traffic conditions?
Thanks,
Vivek.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
