// add rtw88 USB author Sascha for his comments.
> -----Original Message-----
> From: Dmitry Antipov <dmantipov@xxxxxxxxx>
> Sent: Friday, June 16, 2023 4:59 PM
> To: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
> Cc: Kalle Valo <kvalo@xxxxxxxxxx>; linux-wireless@xxxxxxxxxxxxxxx; Dmitry Antipov <dmantipov@xxxxxxxxx>
> Subject: [PATCH 3/3] [v3] wifi: rtw88: remove unused USB bulkout size set
>
> Drop no longer used 'bulkout_size' of 'struct rtw_usb'
> and related macros from usb.h, but preserve sanity check
> in 'rtw_usb_parse()'. This follows commit 462c8db6a011
> ("wifi: rtw88: usb: drop now unnecessary URB size check").
>
> Signed-off-by: Dmitry Antipov <dmantipov@xxxxxxxxx>
> ---
> drivers/net/wireless/realtek/rtw88/usb.c | 5 -----
> drivers/net/wireless/realtek/rtw88/usb.h | 5 -----
> 2 files changed, 10 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw88/usb.c b/drivers/net/wireless/realtek/rtw88/usb.c
> index 6862338b1d51..40e614f58349 100644
> --- a/drivers/net/wireless/realtek/rtw88/usb.c
> +++ b/drivers/net/wireless/realtek/rtw88/usb.c
> @@ -186,13 +186,8 @@ static int rtw_usb_parse(struct rtw_dev *rtwdev,
> switch (usbd->speed) {
> case USB_SPEED_LOW:
> case USB_SPEED_FULL:
> - rtwusb->bulkout_size = RTW_USB_FULL_SPEED_BULK_SIZE;
> - break;
> case USB_SPEED_HIGH:
> - rtwusb->bulkout_size = RTW_USB_HIGH_SPEED_BULK_SIZE;
> - break;
> case USB_SPEED_SUPER:
> - rtwusb->bulkout_size = RTW_USB_SUPER_SPEED_BULK_SIZE;
> break;
> default:
> rtw_err(rtwdev, "failed to detect usb speed\n");
If we decide to remove rtwusb->bulkout_size, I suggest to remove whole
switch..case chunk.
