Search Linux Wireless

Re: [PATCH] wifi: mt76: mt7996: fix endianness warning in mt7996_mac_write_txwi

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Lorenzo Bianconi <lorenzo@xxxxxxxxxx> wrote:
> 
> > Fix the following endianness warning in mt7996_mac_write_txwi routine:
> > 
> > drivers/net/wireless/mediatek/mt76/mt7996/mac.c:1091:25: warning: invalid assignment: |=
> > drivers/net/wireless/mediatek/mt76/mt7996/mac.c:1091:25:    left side has type restricted __le32
> > drivers/net/wireless/mediatek/mt76/mt7996/mac.c:1091:25:    right side has type unsigned long
> > 
> > Fixes: 15ee62e73705 ("wifi: mt76: mt7996: enable BSS_CHANGED_BASIC_RATES support")
> > Signed-off-by: Lorenzo Bianconi <lorenzo@xxxxxxxxxx>
> > Reviewed-by: Simon Horman <simon.horman@xxxxxxxxxxxx>
> 
> Failed to apply, please rebase over wireless tree.
> 
> error: sha1 information is lacking or useless (drivers/net/wireless/mediatek/mt76/mt7996/mac.c).
> error: could not build fake ancestor
> hint: Use 'git am --show-current-patch=diff' to see the failed patch
> Applying: wifi: mt76: mt7996: fix endianness warning in mt7996_mac_write_txwi
> Patch failed at 0001 wifi: mt76: mt7996: fix endianness warning in mt7996_mac_write_txwi
> 
> Patch set to Changes Requested.

Hi Kalle,

my bad, it seems there is already a fix for this issue:

commit cdc26ee89bddb9b6b2ae026a46d97855d5ba6694
Author: Ryder Lee <ryder.lee@xxxxxxxxxxxx>
Date:   Mon Apr 24 05:39:05 2023 +0800

    wifi: mt76: mt7996: fix endianness of MT_TXD6_TX_RATE

    To avoid sparse warning:
    sparse: warning: invalid assignment: |=
    sparse:    left side has type restricted __le32
    sparse:    right side has type unsigned lon

    Fixes: 15ee62e73705 ("wifi: mt76: mt7996: enable BSS_CHANGED_BASIC_RATES support")

we can drop this patch. Sorry for the noise.

Regards,
Lorenzo

> 
> -- 
> https://patchwork.kernel.org/project/linux-wireless/patch/9509f4bc32d9321f3419a3c0029a01b426f13fd8.1684746447.git.lorenzo@xxxxxxxxxx/
> 
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
> 

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux