On Fri, 2023-05-26 at 19:55 +0800, Ping-Ke Shih wrote: > On Thu, 2023-05-25 at 13:36 -0500, Larry Finger wrote: > > On 5/25/23 13:05, Johannes Berg wrote: > > > Yeah, I think I saw the report, but I'm travelling and didn't have that > > > much time to reply. > > > > Johannes, > > > > The rtw88 drivers are definitely setting both SUPPORTS_PS and > > SUPPORTS_DYNAMIC_PS. It seems that there is a bug somewhere is those drivers. > > > > In my repo, I will remove the SUPPORTS_DYNAMIC_PS, which will solve the problem > > raised in the GitHub issue. That will give me time to find that bug. > > > > We also have been aware of this a couple days ago, so we are preparing patches > to correct this for both rtw88/89. The method is that re-calculate if we can > enter PS by changes of BSS_CHANGED_PS and vif->cfg.ps. > I will submit the patch soon. > > Hi Larry, I have sent fixes [1]. Please see the patchset about the detail. [1] https://lore.kernel.org/linux-wireless/20230527082939.11206-1-pkshih@xxxxxxxxxxx/T/#t Ping-Ke
