On Sun, May 21, 2023 at 08:23:53PM +0200, Tom Psyborg wrote: > Hello > > This was all taken from reference driver. > i did not go through detailed debugging to see if the value is > overwritten in vendor driver. > > Maybe ask devs from openwrt who upstreamed these patches > The code is clear enough. We could either just delete the underflow check or change the array to an array of ints instead of char. It's more of a philosophical question. regards, dan carpenter