Nikita Zhandarovich <n.zhandarovich@xxxxxxxxxx> wrote: > Since second call of ssb_get_devtypedata() may fail as well as the > first one, the NULL return value in 'wl' will be later dereferenced in > calls to b43legacy_one_core_attach() and schedule_work(). > > Instead of merely warning about this failure with > B43legacy_WARN_ON(), properly return with error to avoid any further > NULL pointer dereferences. > > Found by Linux Verification Center (linuxtesting.org) with static > analysis tool SVACE. > > Fixes: 75388acd0cd8 ("[B43LEGACY]: add mac80211-based driver for legacy BCM43xx devices") > Co-developed-by: Natalia Petrova <n.petrova@xxxxxxxxxx> > Signed-off-by: Nikita Zhandarovich <n.zhandarovich@xxxxxxxxxx> > Reviewed-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx> Dropped per Michael's request. Patch set to Rejected. -- https://patchwork.kernel.org/project/linux-wireless/patch/20230418142918.70510-1-n.zhandarovich@xxxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches