On Fri, 21 Apr 2023 17:14:18 -0500
Larry Finger <Larry.Finger@xxxxxxxxxxxx> wrote:
> > (err) goto out;
> > wl = ssb_get_devtypedata(dev);
> > - B43legacy_WARN_ON(!wl);
> > + if (!wl) {
> > + B43legacy_WARN_ON(!wl);
> > + err = -ENODEV;
> > + goto out;
> > + }
> > }
> > err = b43legacy_one_core_attach(dev, wl);
> > if (err)
>
> I do not recall seeing v1. One additional nitpick: The latest
> convention would have the subject as "wifi: b43legacy:...". Kalle may
> be able to fix this on merging, but it not, a v3 might be required.
> Otherwise, the patch is good.
>
> Reviewed-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx>
No, it's not good. It's wrong. I already replied to it.
wl can never be NULL here and the goto-out path is wrong (if there
was a chance for it to trigger).
Please drop this patch, Kalle.
--
Michael Büsch
https://bues.ch/
Attachment:
pgp9BY3NjJNNU.pgp
Description: OpenPGP digital signature
