On Tue, May 02, 2023 at 09:10:04AM +0000, Ping-Ke Shih wrote: > > > > > -----Original Message----- > > From: Kevin Lo <kevlo@xxxxxxxxx> > > Sent: Friday, April 28, 2023 2:35 PM > > To: Kalle Valo <kvalo@xxxxxxxxxx> > > Cc: linux-wireless@xxxxxxxxxxxxxxx; Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx>; Jes Sorensen > > <Jes.Sorensen@xxxxxxxxx>; Ping-Ke Shih <pkshih@xxxxxxxxxxx> > > Subject: Re: [PATCH v2] wifi: rtl8xxxu: 8188f: no need to initialize interrupts > > > > On Fri, Apr 28, 2023 at 08:40:34AM +0300, Kalle Valo wrote: > > > > > > Kevin Lo <kevlo@xxxxxxxxx> writes: > > > > > > > There's no need to initialize interrupts for RTL8188FTV like the vendor driver. > > > > > > > > Signed-off-by: Kevin Lo <kevlo@xxxxxxxxx> > > > > > > Why do this, what's the benefit? Or is this just a theoretical fix. The > > > commit log should explain this. > > > > If I understand correctly, just like rtw88 usb devices, rtl8xxxu has no > > hardware interrupt. > > > > With/without hardware interrupt, it depends on IMR (interrupt mask register) > setting. If it is enabled, driver can receive C2H, PS indicators, and beacon > TBTT events via certain USB endpoint. But, normally vendor driver doesn't > use them neither. > > Why it initializes interrupt in this patch is to reset ISR (interrupt status > register) to avoid unexpected interrupts are received. So, if it doesn't > really enable interrupt by IMR, I suppose it should work well even without > this patch. > > Kevin, could I know the real problem you met? Ping-Ke, many thanks for the clear explanation. I didn't encounter any problems. As you mentioned, while the vendor driver doesn't have IMR settings, there is no harm in initializing interrupts. Please drop this patch, thanks. > Ping-Ke Regards, Kevin
