On Wed, 2008-11-05 at 19:27 +0800, Johannes Berg wrote: > > > This example is not correct, mac80211 will only support multiple virtual > > > interfaces when the driver allows this via add_interface (which I don't > > > think yours does) and it will *never* tell you about monitor interfaces at > > > all except by way of configuring the filter differently. > > > > We do support add_interface in iwlagn. But it works correctly only if > > the second one is a monitor interface. > > But like I said, add_interface is _never_ called with _MONITOR. I'm confused. We do hook up in the configure_filter handler to set up the monitor. I assume you did read our code in iwl-agn.c. No? > > > Therefore, all the "is monitor" checks in iwlwifi are pretty pointless > > > unless you really want to have differing behaviour between "monitor + > > > something" and "just monitor"? > > > > In case of BSS + monitor, we need to tell firmware about the > > association status. This differs with pure montior mode. > > You can only distinguish those by the filter flags, and should probably > base the firmware knowledge on that. We want to be able to pull up > "plain" monitor interfaces w/o any special flags that show things > exactly as they'd go to mac80211 if the monitor interface was not > present. I suspect you should look at the FIF_OTHER_BSS flag? We do handle FIF_OTHER_BSS in configure_filter. Please take a look at it and let me know if anything is wrong. Thanks, -yi -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
