On Tue, 2023-04-25 at 07:18 -0700, Jakub Kicinski wrote: > On Tue, 25 Apr 2023 08:38:17 +0300 Kalle Valo wrote: > > IIRC we discussed this back in initial rtw88 or rtw89 driver review (not > > sure which one). At the time I pushed for the current solution to have > > the initvals in static variables just to avoid any backwards > > compatibility issues. I agree that the initvals in .c files are ugly but > > is it worth all the extra effort and complexity to move them outside the > > kernel? I'm starting to lean towards it's not worth all the extra work. > > I don't think it's that much extra work, the driver requires FW > according to modinfo, anyway, so /lib/firmware is already required. If the firmware is sufficiently unique to a device (which is likely) it could even just be appended to that same file, assuming the file format has any kind of container layout. But even that could be done fairly easily. johannes
