Aloka Dixit <quic_alokad@xxxxxxxxxxx> writes: > On 4/3/2023 3:51 PM, Aloka Dixit wrote: > >> Add new parameters and prepare the association data for an EHT peer. >> MCS data uses the format described in IEEE P802.11be/D2.0, May 2022, >> 9.4.2.313.4, convert it into the format expected by the firmware. >> >> + case IEEE80211_STA_RX_BW_320: >> + bw = &eht_cap->eht_mcs_nss_supp.bw._320; >> + ath12k_mac_set_eht_mcs(bw->rx_tx_mcs9_max_nss, >> + bw->rx_tx_mcs9_max_nss, >> + bw->rx_tx_mcs11_max_nss, >> + bw->rx_tx_mcs13_max_nss, >> + &rx_mcs[WMI_EHTCAP_TXRX_MCS_NSS_IDX_320], >> + &tx_mcs[WMI_EHTCAP_TXRX_MCS_NSS_IDX_320]); >> + arg->peer_eht_mcs_count++; >> + fallthrough; >> + >> + case IEEE80211_STA_RX_BW_160: >> + bw = &eht_cap->eht_mcs_nss_supp.bw._160; >> + ath12k_mac_set_eht_mcs(bw->rx_tx_mcs9_max_nss, >> + bw->rx_tx_mcs9_max_nss, >> + bw->rx_tx_mcs11_max_nss, >> + bw->rx_tx_mcs13_max_nss, >> + &rx_mcs[WMI_EHTCAP_TXRX_MCS_NSS_IDX_160], >> + &tx_mcs[WMI_EHTCAP_TXRX_MCS_NSS_IDX_160]); >> + fallthrough; >> + > > 'arg->peer_eht_mcs_count++' is missing for 160 MHz case. > Should I send a follow-up now for the series or wait for comments on > the remaining part for some time. Sending a new version sounds like the best. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches