Search Linux Wireless

Re: [BUG v6.2.7] Hitting BUG_ON() on rtw89 wireless driver startup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/22/23 19:59, Ping-Ke Shih wrote:
diff --git a/pci.c b/pci.c
index fe6c0efc..087de2e0 100644
--- a/pci.c
+++ b/pci.c
@@ -3879,25 +3879,26 @@ int rtw89_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
         rtw89_pci_link_cfg(rtwdev);
         rtw89_pci_l1ss_cfg(rtwdev);

-       ret = rtw89_core_register(rtwdev);
-       if (ret) {
-               rtw89_err(rtwdev, "failed to register core\n");
-               goto err_clear_resource;
-       }
-
         rtw89_core_napi_init(rtwdev);

         ret = rtw89_pci_request_irq(rtwdev, pdev);
         if (ret) {
                 rtw89_err(rtwdev, "failed to request pci irq\n");
-               goto err_unregister;
+               goto err_deinit_napi;
+       }
+
+       ret = rtw89_core_register(rtwdev);
+       if (ret) {
+               rtw89_err(rtwdev, "failed to register core\n");
+               goto err_free_irq;
         }

         return 0;

-err_unregister:
+err_free_irq:
+       rtw89_pci_free_irq(rtwdev, pdev);
+err_deinit_napi:
         rtw89_core_napi_deinit(rtwdev);
-       rtw89_core_unregister(rtwdev);
  err_clear_resource:
         rtw89_pci_clear_resource(rtwdev, pdev);
  err_declaim_pci:

Hyeonggon,

I have tested the above patch and added it to my GitHub repo that I mentioned earlier. Using the repo, you will be able to get the new code without patching and regenerating an entire new kernel.

Larry




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux