On Wed, Mar 01, 2023 at 12:32:38AM +0000, Ping-Ke Shih wrote: > > > > -----Original Message----- > > From: Simon Horman <simon.horman@xxxxxxxxxxxx> > > Sent: Tuesday, February 28, 2023 7:07 PM > > To: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx> > > Cc: Ping-Ke Shih <pkshih@xxxxxxxxxxx>; kvalo@xxxxxxxxxx; davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; > > kuba@xxxxxxxxxx; pabeni@xxxxxxxxxx; linux-wireless@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; > > linux-kernel@xxxxxxxxxxxxxxx; Abaci Robot <abaci@xxxxxxxxxxxxxxxxx> > > Subject: Re: [PATCH] rtlwifi: rtl8192se: Remove the unused variable bcntime_cfg > > > > On Tue, Feb 28, 2023 at 10:11:32AM +0800, Jiapeng Chong wrote: > > > Variable bcntime_cfg is not effectively used, so delete it. > > > > > > drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:1555:6: warning: variable 'bcntime_cfg' set but not > > used. > > > > > > Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx> > > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4240 > > > Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx> > > > > Hi Jiapeng Chong, > > > > this looks good to me. > > > > Reviewed-by: Simon Horman <simon.horman@xxxxxxxxxxxx> > > > > While reviewing this gcc 12.2.0 told me: > > > > drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:1555:25: error: unused variable 'bcn_ifs' > > [-Werror=unused-variable] > > 1555 | u16 bcn_cw = 6, bcn_ifs = 0xf; > > | ^~~~~~~ > > drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:1555:13: error: unused variable 'bcn_cw' > > [-Werror=unused-variable] > > 1555 | u16 bcn_cw = 6, bcn_ifs = 0xf; > > | ^~~~~~ > > > > So perhaps you could consider sending another patch to remove them too. > > > > These errors are introduced by this patch, so please fix them together by this > patch. Yes, indeed. Sorry for missing that important point. Had I noticed it my advice would have been the same as yours.
