On Tue, Feb 28, 2023 at 10:11:32AM +0800, Jiapeng Chong wrote: > Variable bcntime_cfg is not effectively used, so delete it. > > drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:1555:6: warning: variable 'bcntime_cfg' set but not used. > > Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx> > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4240 > Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx> Hi Jiapeng Chong, this looks good to me. Reviewed-by: Simon Horman <simon.horman@xxxxxxxxxxxx> While reviewing this gcc 12.2.0 told me: drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:1555:25: error: unused variable 'bcn_ifs' [-Werror=unused-variable] 1555 | u16 bcn_cw = 6, bcn_ifs = 0xf; | ^~~~~~~ drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:1555:13: error: unused variable 'bcn_cw' [-Werror=unused-variable] 1555 | u16 bcn_cw = 6, bcn_ifs = 0xf; | ^~~~~~ So perhaps you could consider sending another patch to remove them too.
