On Wed, 2023-01-18 at 20:46 +0530, Aditya Kumar Singh wrote: > +++ b/net/mac80211/cfg.c > @@ -1488,6 +1488,13 @@ static int ieee80211_stop_ap(struct wiphy *wiphy, struct net_device *dev, > > mutex_unlock(&local->mtx); > > + /* The below work requires sdata lock which we have already acquired > + * here. But before that, it will check whether link_conf->csa_active > + * is true, which we have made false above. Hence, it will not proceed > + * to acquire the sdata lock and deadlock will be avoided. > + */ This is obviously wrong. I know the locking here is hard and that we may need to make some bigger changes to support cancelling these work items properly, but this doesn't address it at all. johannes
