On Thu, 2023-01-19 at 15:32 +0100, Jonas Jelonek wrote: > > > > Not sure I like this either - I think we should probably create the > > wiphys dynamically for most features these days? > > just to make sure I got it correctly: so you propose that these > params, that are > currently done with module_param(), should be switched to a dynamic > netlink approach, or only for TPC and RCTBL for now? We do have dynamic parameters for all the module parameters I believe, but we've shied away from actually removing the existing module parameters for legacy/compatibility reasons. However, I think that for new parameters, there's really no good reason to provide module parameters, since the test scripting etc. can dynamically create wiphys with the necessary capabilities. Even the hostap/hwsim tests can and do already do that :) > As a first step I focused on providing a proof-of-concept > implementation in hwsim for my > TPC proposal, implementing netlink to set tx power and other could be > part of the next step. > Do you think this could be fine or do you propose something different? I'm not quite sure what you mean by that, tbh. I guess I kind of thought you were going to adjust minstrel to do TPC automatically. We already have netlink support for setting per-station TX power which I guess this should then listen to? See NL80211_ATTR_STA_TX_POWER_SETTING and NL80211_ATTR_STA_TX_POWER etc. I think it's not supported in mac80211, but probably could easily be after your patches? johannes
