> On 12. Jan 2023, at 11:31, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > > On Tue, 2022-09-20 at 12:40 +0200, Jonas Jelonek wrote: >> Enable RC_TABLE in hwsim for TPC support and replace the >> ieee80211_tx_status_irqsafe calls with regular ieee80211_tx_status_ext >> calls to be able to pass additional information, i.e., tx-power. >> Add some variables, members and functions in both tx control and tx >> status path to pass and process tx-power. >> >> Signed-off-by: Jonas Jelonek <jelonek.jonas@xxxxxxxxx> >> --- >> drivers/net/wireless/mac80211_hwsim.c | 175 ++++++++++++++++++++++++-- >> drivers/net/wireless/mac80211_hwsim.h | 1 + >> 2 files changed, 168 insertions(+), 8 deletions(-) >> >> diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_hwsim.c >> index df51b5b1f171..a56fb2505047 100644 >> --- a/drivers/net/wireless/mac80211_hwsim.c >> +++ b/drivers/net/wireless/mac80211_hwsim.c >> @@ -57,10 +57,15 @@ static bool paged_rx = false; >> module_param(paged_rx, bool, 0644); >> MODULE_PARM_DESC(paged_rx, "Use paged SKBs for RX instead of linear ones"); >> >> -static bool rctbl = false; >> +static bool rctbl = true; > > should we really change the default? > > Is there a netlink control to set it for newly created wiphys? > >> module_param(rctbl, bool, 0444); >> >> +static int tpc = 0; >> +module_param(tpc, int, 0444); >> +MODULE_PARM_DESC(tpc, "Support transmit power control (TPC) (0 = no,\ >> + 1 = per packet, 2 = per mrr stage)"); > > Not sure I like this either - I think we should probably create the > wiphys dynamically for most features these days? just to make sure I got it correctly: so you propose that these params, that are currently done with module_param(), should be switched to a dynamic netlink approach, or only for TPC and RCTBL for now? As a first step I focused on providing a proof-of-concept implementation in hwsim for my TPC proposal, implementing netlink to set tx power and other could be part of the next step. Do you think this could be fine or do you propose something different? (all other comments from your side I will fix in v3) Jonas
