Manikanta Pubbisetty <quic_mpubbise@xxxxxxxxxxx> writes: > Currently, WLAN chip is powered once during driver probe and is kept > ON (powered) always even when WLAN is not active; keeping the chip > powered ON all the time will consume extra power which is not > desirable for battery operated devices. Same is the case with non-WoW > suspend, chip will not be put into low power mode when the system is > suspended resulting in higher battery drain. > > Send QMI MODE OFF command to firmware during WiFi OFF to put device > into low power mode. > > Tested-on: WCN6750 hw1.0 AHB WLAN.MSL.1.0.1-00887-QCAMSLSWPLZ-1 > Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.16 > > Manikanta Pubbisetty (3): > ath11k: Fix double free issue during SRNG deinit > ath11k: Move hardware initialization logic to start() > ath11k: Enable low power mode when WLAN is not active > --- > V3: > - Removed patch "ath11k: Fix failed to parse regulatory event print" as it is not needed anymore > - Fixed a potential deadlock scenario reported by lockdep around ab->core_lock with V2 changes > - Fixed other minor issues that were found during code review > - Spelling corrections in the commit messages I still see a crash, immediately after the first rmmod: Nov 22 11:05:47 nuc2 [ 139.378719] rmmod ath11k_pci Nov 22 11:05:48 nuc2 [ 139.892395] general protection fault, probably for non-canonical address 0xdffffc000000003e: 0000 [#1] PREEMPT SMP DEBUG_PAGEALLOC KASAN Nov 22 11:05:48 nuc2 [ 139.892453] KASAN: null-ptr-deref in range [0x00000000000001f0-0x00000000000001f7] Really odd that you don't see it. Unfortunately not able to debug this further right now. This is with: wcn6855 hw2.0 WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.9 -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches