On 10/28/22 3:44 AM, Kalle Valo wrote:
"Joseph S. Barrera III" <joebar@xxxxxxxxxxxx> writes:
Do you want to add a comma after that last list element?
I can add that in the pending branch.
I think that would be good.
I would prefer to have a comment to make it more visible that an empty
element is needed at the end, but I would add that outside of braces?
/* end of list */
{},
Ending a list with {}, is such a common idiom that adding a comment
is kind of just noise. And if you look at other such instances of
ending with an empty element, you'll find no comment, just the {},.
When making changes I prefer to stick to the existing coding style
as much as possible, so in this case I would definitely omit the
comment. But if you do feel like you need to add a comment, I would
keep it on the same line as the empty element, probably like
{}, // end of list
