Search Linux Wireless

Re: [PATCH] wifi: ath11k: Fix qmi_msg_handler data structure initialization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 10/28/2022 4:14 PM, Kalle Valo wrote:
"Joseph S. Barrera III" <joebar@xxxxxxxxxxxx> writes:

On 10/21/22 2:01 AM, Rahul Bhattacharjee wrote:

   	},
+	{/* end of list */}
   };
Do you want to add a comma after that last list element?
I can add that in the pending branch.

Actually, I normally see the last list element simply being

+	{},
... with no comment necessary.
I would prefer to have a comment to make it more visible that an empty
element is needed at the end, but I would add that outside of braces?

/* end of list */
{},

Thoughts? I can change this in the pending branch.

LGTM!



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux