On Tue, Oct 25, 2022 at 10:09 PM Kalle Valo <kvalo@xxxxxxxxxx> wrote: > Arend Van Spriel <arend.vanspriel@xxxxxxxxxxxx> writes: > > > On October 24, 2022 2:40:08 PM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > > > >> The driver looks up the BCMA parent GPIO driver and checks that > >> this succeeds, but then it goes on to use the deprecated GPIO > >> call gpio_is_valid() to check the consistency of the .base > >> member of the BCMA GPIO struct. Surely this belongs in the > >> BCMA driver: we cannot have all drivers performing cosistency > > > > Should be: consistency > > > >> > >> checks on the internals of things they are passed. > > > > Apart from the typo in the subject and missing wifi: prefix (replace > > 'brcm80211' by 'wifi')... > > I can fix those. I am sending a combined patch with this and the other bcma patch because they happen to depend on each other. Dunno how to tag a patch that affects bcma and brcn80211 at the same time so you will probably have to edit it anyway. Yours, Linus Walleij
