On October 24, 2022 2:40:08 PM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
The driver looks up the BCMA parent GPIO driver and checks that this succeeds, but then it goes on to use the deprecated GPIO call gpio_is_valid() to check the consistency of the .base member of the BCMA GPIO struct. Surely this belongs in the BCMA driver: we cannot have all drivers performing cosistency
Should be: consistency
checks on the internals of things they are passed.
Apart from the typo in the subject and missing wifi: prefix (replace 'brcm80211' by 'wifi')...
Acked-by: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx>
Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> --- drivers/net/wireless/broadcom/brcm80211/brcmsmac/led.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
