> -----Original Message-----
> From: Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx>
> Sent: Tuesday, October 25, 2022 4:59 AM
> To: linux-wireless@xxxxxxxxxxxxxxx
> Cc: Jes Sorensen <Jes.Sorensen@xxxxxxxxx>
> Subject: [PATCH v2 5/5] wifi: rtl8xxxu: Use dev_info instead of pr_info
>
> Replace two instances of bare pr_info with dev_info.
>
> Also make their messages a little more informative.
>
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx>
Reviewed-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
> ---
> v2:
> - No change.
> ---
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> index 8bab7247460d..9d5ae83dad70 100644
> --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> @@ -2015,7 +2015,8 @@ static int rtl8xxxu_download_firmware(struct rtl8xxxu_priv *priv)
>
> val8 = rtl8xxxu_read8(priv, REG_MCU_FW_DL);
> if (val8 & MCU_FW_RAM_SEL) {
> - pr_info("do the RAM reset\n");
> + dev_info(&priv->udev->dev,
> + "Firmware is already running, resetting the MCU.\n");
> rtl8xxxu_write8(priv, REG_MCU_FW_DL, 0x00);
> priv->fops->reset_8051(priv);
> }
> @@ -5420,7 +5421,8 @@ static void rtl8xxxu_rx_urb_work(struct work_struct *work)
> rtl8xxxu_queue_rx_urb(priv, rx_urb);
> break;
> default:
> - pr_info("failed to requeue urb %i\n", ret);
> + dev_info(&priv->udev->dev,
> + "failed to requeue urb with error %i\n", ret);
> skb = (struct sk_buff *)rx_urb->urb.context;
> dev_kfree_skb(skb);
> usb_free_urb(&rx_urb->urb);
> --
> 2.38.0
>
> ------Please consider the environment before printing this e-mail.
