On Tue, Oct 18, 2022 at 02:27:34PM -0600, Jason A. Donenfeld wrote: > On some platforms, `char` is unsigned, which makes casting -7 to char > overflow, which in turn makes the clamping operation bogus. Instead, > deal with an explicit `s8` type, so that the comparison is always > signed, and return an s8 result from the function as well. Note that > this function's result is assigned to a `short`, which is always signed. > > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > Cc: Stanislaw Gruszka <stf_xl@xxxxx> > Cc: Helmut Schaa <helmut.schaa@xxxxxxxxxxxxxx> > Cc: Kalle Valo <kvalo@xxxxxxxxxx> > Signed-off-by: Jason A. Donenfeld <Jason@xxxxxxxxx> I prefer s8 just because is shorter name than short :-) Acked-by: Stanislaw Gruszka <stf_xl@xxxxx>
