Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> writes: > On 26/09/2022 12:22, Kalle Valo wrote: > >> Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> writes: >> >> [...] >> >>> +static struct rtl8xxxu_reg8val rtl8188f_mac_init_table[] = { >> >> [...] >> >>> +static struct rtl8xxxu_reg32val rtl8188fu_phy_init_table[] = { >> >> [...] >> >>> +static struct rtl8xxxu_reg32val rtl8188f_agc_table[] = { >> >> [...] >> >>> +static struct rtl8xxxu_rfregval rtl8188fu_radioa_init_table[] = { >> >> [...] >> >>> +static struct rtl8xxxu_rfregval rtl8188fu_cut_b_radioa_init_table[] = { >> >> Can these arrays be static const? >> > Only if I modify the functions rtl8xxxu_init_phy_regs and > rtl8xxxu_init_phy_rf, and the struct rtl8xxxu_fileops. Otherwise the > compiler complains about discarded const. Perhaps in a future patch? Yeah, a future patch sounds good. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches