Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> writes: > This chip is found in the cheapest USB adapters, e.g. 1.17 USD with > VAT and shipping from China included. > > It's a gen 2 chip, similar to the RTL8723BU, but without Bluetooth. > Features: 2.4 GHz, b/g/n mode, 1T1R, 150 Mbps. > > The vendor driver rtl8188fu version 4.3.23.6_20964.20170110 [0] > was used as reference. The CD shipped with the device includes a > newer driver, version 5.11.5-1-g12f7cde4b.20201102, but that one > couldn't complete the WPA2 key exchange thing for whatever reason. > > [0] https://github.com/kelebek333/rtl8188fu > > Signed-off-by: Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> [...] > diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c > new file mode 100644 > index 000000000000..5f7f9ea4d1d5 > --- /dev/null > +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c > @@ -0,0 +1,1696 @@ > +/* > + * RTL8XXXU mac80211 USB driver - 8188f specific subdriver > + * > + * Copyright (c) 2022 Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> > + * > + * Portions copied from existing rtl8xxxu code: > + * Copyright (c) 2014 - 2017 Jes Sorensen <Jes.Sorensen@xxxxxxxxx> > + * > + * Portions, notably calibration code: > + * Copyright(c) 2007 - 2011 Realtek Corporation. All rights reserved. > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms of version 2 of the GNU General Public License as > + * published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, but WITHOUT > + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or > + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for > + * more details. > + */ Please use SPDX tags instead of the license text, you can see examples from other rtl8xxxu files. > +static struct rtl8xxxu_reg8val rtl8188f_mac_init_table[] = { [...] > +static struct rtl8xxxu_reg32val rtl8188fu_phy_init_table[] = { [...] > +static struct rtl8xxxu_reg32val rtl8188f_agc_table[] = { [...] > +static struct rtl8xxxu_rfregval rtl8188fu_radioa_init_table[] = { [...] > +static struct rtl8xxxu_rfregval rtl8188fu_cut_b_radioa_init_table[] = { Can these arrays be static const? > +/* A workaround to eliminate the 2400MHz, 2440MHz, 2480MHz spur of 8188F. */ > +static void rtl8188f_spur_calibration(struct rtl8xxxu_priv *priv, u8 channel) > +{ > + const u32 frequencies[14 + 1] = { > + [5] = 0xFCCD, > + [6] = 0xFC4D, > + [7] = 0xFFCD, > + [8] = 0xFF4D, > + [11] = 0xFDCD, > + [13] = 0xFCCD, > + [14] = 0xFF9A > + }; > + > + const u32 reg_d40[14 + 1] = { > + [5] = 0x06000000, > + [6] = 0x00000600, > + [13] = 0x06000000 > + }; > + > + const u32 reg_d44[14 + 1] = { > + [11] = 0x04000000 > + }; > + > + const u32 reg_d4c[14 + 1] = { > + [7] = 0x06000000, > + [8] = 0x00000380, > + [14] = 0x00180000 > + }; Also can these be static const? > + /*enable notch filter */ Add a space after '/*': /* enable notch filter */ I see similar problems in other comments, please go through them. This is nitpicking, but to improve readability I prefer to have an empty line before a comment. I saw several cases which didn't have that. > + if (t) { > + if (!priv->pi_enabled) { > + /* > + * Switch back BB to SI mode after finishing > + * IQ Calibration > + */ > + val32 = 0x01000000; > + rtl8xxxu_write32(priv, REG_FPGA0_XA_HSSI_PARM1, val32); > + rtl8xxxu_write32(priv, REG_FPGA0_XB_HSSI_PARM1, val32); > + } > + > + /* Reload ADDA power saving parameters */ > + rtl8xxxu_restore_regs(priv, adda_regs, priv->adda_backup, > + RTL8XXXU_ADDA_REGS); > + > + /* Reload MAC parameters */ > + rtl8xxxu_restore_mac_regs(priv, iqk_mac_regs, priv->mac_backup); > + > + /* Reload BB parameters */ > + rtl8xxxu_restore_regs(priv, iqk_bb_regs, > + priv->bb_backup, RTL8XXXU_BB_REGS); > + > + /* Reload RF path */ > + rtl8xxxu_write32(priv, REG_S0S1_PATH_SWITCH, path_sel_bb); > + rtl8xxxu_write_rfreg(priv, RF_A, RF6052_REG_S0S1, path_sel_rf); > + > + /* Restore RX initial gain */ > + val32 = rtl8xxxu_read32(priv, REG_OFDM0_XA_AGC_CORE1); > + val32 &= 0xffffff00; > + val32 |= 0x50; > + rtl8xxxu_write32(priv, REG_OFDM0_XA_AGC_CORE1, val32); > + rtl8xxxu_write32(priv, REG_OFDM0_XA_AGC_CORE1, rx_initial_gain & 0xff); > + > + /* Load 0xe30 IQC default value */ > + rtl8xxxu_write32(priv, REG_TX_IQK_TONE_A, 0x01008c00); > + rtl8xxxu_write32(priv, REG_RX_IQK_TONE_A, 0x01008c00); > + } > +} You can avoid the indentation and extra block with: if (!t) return; > +static void rtl8188f_enable_rf(struct rtl8xxxu_priv *priv) > +{ > +#define PPG_BB_GAIN_2G_TXA_OFFSET_8188F 0xee > +#define PPG_BB_GAIN_2G_TX_OFFSET_MASK 0x0f Please move the defines outside of the function (ie. few lines above). -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
