> -----Original Message-----
> From: Kalle Valo <kvalo@xxxxxxxxxx>
> Sent: Thursday, September 8, 2022 3:07 PM
> To: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
> Cc: linux-wireless@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v2 3/5] wifi: rtw89: configure TX path via H2C command
>
> Ping-Ke Shih <pkshih@xxxxxxxxxxx> writes:
>
> > In order to support TX diversity, add a function to control TX path.
> >
> > Signed-off-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
>
> [...]
>
> > + ret = rtw89_h2c_tx(rtwdev, skb, false);
> > + if (ret) {
> > + rtw89_err(rtwdev, "failed to send h2c\n");
> > + goto fail;
> > + }
> > +
> > + return 0;
> > +fail:
> > + dev_kfree_skb_any(skb);
> > +
> > + return -EBUSY;
>
> Overwriting error codes is confusing, so it would be better that this is
> 'return ret'.
>
Sorry for the mistakes. Fixed by v3.
