Ping-Ke Shih <pkshih@xxxxxxxxxxx> writes: > In order to support TX diversity, add a function to control TX path. > > Signed-off-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx> [...] > + ret = rtw89_h2c_tx(rtwdev, skb, false); > + if (ret) { > + rtw89_err(rtwdev, "failed to send h2c\n"); > + goto fail; > + } > + > + return 0; > +fail: > + dev_kfree_skb_any(skb); > + > + return -EBUSY; Overwriting error codes is confusing, so it would be better that this is 'return ret'. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches