Search Linux Wireless

Re: [PATCH v3 07/12] mac80211: S1G capabilities information element in probe request

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Feels like somewhere in this patch you should consider the size of the
new element?
 
>  /* channel management */
>  bool ieee80211_chandef_ht_oper(const struct ieee80211_ht_operation *ht_oper,
> diff --git a/net/mac80211/util.c b/net/mac80211/util.c
> index 53826c663723..78e8c286011e 100644
> --- a/net/mac80211/util.c
> +++ b/net/mac80211/util.c
> @@ -1857,6 +1857,12 @@ static int ieee80211_build_preq_ies_band(struct ieee80211_sub_if_data *sdata,
>  	rate_flags = ieee80211_chandef_rate_flags(chandef);
>  	shift = ieee80211_chandef_get_shift(chandef);
>  
> +	/* For direct mac80211 scan (probe request), add S1G IE and consider its override bits */
> +	if (band == NL80211_BAND_S1GHZ) {
> +		pos = ieee80211_ie_build_s1g_cap(pos, &sband->s1g_cap);
> +		goto done;
> +	}
> 

Though off the top of my head I'm not really sure how it works for the
other bits.

johannes




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux